1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tools: don't use GH API for commit message checks

Browse Source 
Fixes: https://github.com/nodejs/node/issues/24567

PR-URL: https://github.com/nodejs/node/pull/24574
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This commit is contained in:
Rod Vagg 2018-11-23 12:55:28 +11:00 committed by Rich Trott
parent f34ca9f783
commit 76faccccbb
1 changed files with 11 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
tools/lint-pr-commit-message.sh
View File

@ -25,21 +25,15 @@ if [ -z "${PR_ID}" ]; then
echo " e.g. $0 <PR_NUMBER>" echo " e.g. $0 <PR_NUMBER>"
exit 1 exit 1
fi fi
# Retrieve the first commit of the pull request via GitHub API
# TODO: If we teach core-validate-commit to ignore "fixup!" and "squash!" PATCH=$( curl -sL https://github.com/nodejs/node/pull/${PR_ID}.patch | grep '^From ' )
# commits and lint messages for all commits in the pull request if FIRST_COMMIT="$( echo "$PATCH" | awk '/^From [0-9a-f]{40} / { if (count++ == 0) print $2 }' )"; then
# we could simplify the following to: MESSAGE=$( git show --quiet --format='format:%B' $FIRST_COMMIT )
# npx -q core-validate-commit --no-validate-metadata ${GH_API_URL}/repos/nodejs/node/pulls/${PR_ID}/commits echo "
if PR_COMMITS="$( curl -s ${GH_API_URL}/repos/nodejs/node/pulls/${PR_ID}/commits )"; then *** Linting the first commit message for pull request ${PR_ID}
if FIRST_COMMIT="$( node -p 'JSON.parse(process.argv[1])[0].url' "${PR_COMMITS}" 2> /dev/null )"; then *** according to the guidelines at https://goo.gl/p2fr5Q.
echo "Linting the first commit message for pull request ${PR_ID}" *** Commit message for $(echo $FIRST_COMMIT | cut -c 1-10) is:
echo "according to the guidelines at https://goo.gl/p2fr5Q." ${MESSAGE}
# Print the commit message to make it more obvious what is being checked. "
echo "Commit message for ${FIRST_COMMIT##*/} is:" npx -q core-validate-commit --no-validate-metadata "${FIRST_COMMIT}"
node -p 'JSON.parse(process.argv[1])[0].commit.message' "${PR_COMMITS}" 2> /dev/null
npx -q core-validate-commit --no-validate-metadata "${FIRST_COMMIT}"
else
echo "Unable to determine the first commit for pull request ${PR_ID}."
exit 1
fi
fi fi