1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve test-event-emitter-modify-in-emit

Browse Source 
* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: https://github.com/nodejs/node/pull/10600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Adrian Estrada 2017-01-06 12:52:23 -05:00 committed by Luigi Pinca
parent c04d4df08c
commit 75ebd19d8d
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/parallel/test-event-emitter-modify-in-emit.js
View File

@ -3,7 +3,7 @@ require('../common');
const assert = require('assert');
const events = require('events');
var callbacks_called = [];
let callbacks_called = [];
const e = new events.EventEmitter();
@ -25,27 +25,27 @@ function callback3() {
}
e.on('foo', callback1);
assert.equal(1, e.listeners('foo').length);
assert.strictEqual(e.listeners('foo').length, 1);
e.emit('foo');
assert.equal(2, e.listeners('foo').length);
assert.strictEqual(e.listeners('foo').length, 2);
assert.deepStrictEqual(['callback1'], callbacks_called);
e.emit('foo');
assert.equal(0, e.listeners('foo').length);
assert.strictEqual(e.listeners('foo').length, 0);
assert.deepStrictEqual(['callback1', 'callback2', 'callback3'],
callbacks_called);
e.emit('foo');
assert.equal(0, e.listeners('foo').length);
assert.strictEqual(e.listeners('foo').length, 0);
assert.deepStrictEqual(['callback1', 'callback2', 'callback3'],
callbacks_called);
e.on('foo', callback1);
e.on('foo', callback2);
assert.equal(2, e.listeners('foo').length);
assert.strictEqual(e.listeners('foo').length, 2);
e.removeAllListeners('foo');
assert.equal(0, e.listeners('foo').length);
assert.strictEqual(e.listeners('foo').length, 0);
// Verify that removing callbacks while in emit allows emits to propagate to
// all listeners
@ -53,7 +53,7 @@ callbacks_called = [];
e.on('foo', callback2);
e.on('foo', callback3);
assert.equal(2, e.listeners('foo').length);
assert.strictEqual(2, e.listeners('foo').length);
e.emit('foo');
assert.deepStrictEqual(['callback2', 'callback3'], callbacks_called);
assert.equal(0, e.listeners('foo').length);
assert.strictEqual(0, e.listeners('foo').length);