1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve debug output in trace-events test

Browse Source 
test-trace-events-fs-sync is swallowing useful information when it
fails. This change results in more information being displayed.

PR-URL: https://github.com/nodejs/node/pull/21120
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Rich Trott 2018-06-04 11:34:09 +02:00
parent 227ca87abb
commit 75e9165988
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/parallel/test-trace-events-fs-sync.js
View File

@ -3,6 +3,7 @@ const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const cp = require('child_process'); const cp = require('child_process');
const fs = require('fs'); const fs = require('fs');
const util = require('util');
if (!common.isMainThread) if (!common.isMainThread)
common.skip('process.chdir is not available in Workers'); common.skip('process.chdir is not available in Workers');
@ -121,7 +122,8 @@ for (const tr in tests) {
const proc = cp.spawnSync(process.execPath, const proc = cp.spawnSync(process.execPath,
[ '--trace-events-enabled', [ '--trace-events-enabled',
'--trace-event-categories', 'node.fs.sync', '--trace-event-categories', 'node.fs.sync',
'-e', tests[tr] ]); '-e', tests[tr] ],
{ encoding: 'utf8' });
// Some AIX versions don't support futimes or utimes, so skip. // Some AIX versions don't support futimes or utimes, so skip.
if (common.isAIX && proc.status !== 0 && tr === 'fs.sync.futimes') { if (common.isAIX && proc.status !== 0 && tr === 'fs.sync.futimes') {
continue; continue;
@ -131,7 +133,7 @@ for (const tr in tests) {
} }
// Make sure the operation is successful. // Make sure the operation is successful.
assert.strictEqual(proc.status, 0, tr + ': ' + proc.stderr); assert.strictEqual(proc.status, 0, `${tr}:\n${util.inspect(proc)}`);
// Confirm that trace log file is created. // Confirm that trace log file is created.
assert(common.fileExists(traceFile)); assert(common.fileExists(traceFile));