1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: modernize JS and tighten equality checking

Browse Source 
Node todo process example with the follow test-net-binary.js changes:

var --> const where applicable

==, assert.equal--> ===, assert.strictEqual for all cases

PR-URL: https://github.com/nodejs/node/pull/8476
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Peter Ogilvie 2016-09-09 17:52:21 -07:00 committed by Rich Trott
parent 77e9679600
commit 759cf17228
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
test/parallel/test-net-binary.js
View File

@ -1,14 +1,14 @@
/* eslint-disable strict */ /* eslint-disable strict */
require('../common'); require('../common');
var assert = require('assert'); const assert = require('assert');
var net = require('net'); const net = require('net');
var binaryString = ''; var binaryString = '';
for (var i = 255; i >= 0; i--) { for (var i = 255; i >= 0; i--) {
var s = '\'\\' + i.toString(8) + '\''; const s = `'\\${i.toString(8)}'`;
var S = eval(s); const S = eval(s);
assert.ok(S.charCodeAt(0) == i); assert.strictEqual(S.charCodeAt(0), i);
assert.ok(S == String.fromCharCode(i)); assert.strictEqual(S, String.fromCharCode(i));
binaryString += S; binaryString += S;
} }
@ -28,13 +28,13 @@ var recv = '';
echoServer.on('listening', function() { echoServer.on('listening', function() {
var j = 0; var j = 0;
var c = net.createConnection({ const c = net.createConnection({
port: this.address().port port: this.address().port
}); });
c.setEncoding('latin1'); c.setEncoding('latin1');
c.on('data', function(chunk) { c.on('data', function(chunk) {
var n = j + chunk.length; const n = j + chunk.length;
while (j < n && j < 256) { while (j < n && j < 256) {
c.write(String.fromCharCode(j), 'latin1'); c.write(String.fromCharCode(j), 'latin1');
j++; j++;
@ -57,11 +57,11 @@ echoServer.on('listening', function() {
process.on('exit', function() { process.on('exit', function() {
assert.equal(2 * 256, recv.length); assert.equal(2 * 256, recv.length);
var a = recv.split(''); const a = recv.split('');
var first = a.slice(0, 256).reverse().join(''); const first = a.slice(0, 256).reverse().join('');
var second = a.slice(256, 2 * 256).join(''); const second = a.slice(256, 2 * 256).join('');
assert.equal(first, second); assert.strictEqual(first, second);
}); });