1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: remove "make that" from onboarding.md

Browse Source 
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/16

PR-URL: https://github.com/nodejs/node/pull/28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Rich Trott 2019-06-20 13:25:25 -06:00
parent 00907980f0
commit 73d22d1434
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/onboarding.md
View File

@ -124,7 +124,7 @@ onboarding session.
* Be aware: Your opinion carries a lot of weight! * Be aware: Your opinion carries a lot of weight!
* Nits (requests for small changes that are not essential) are fine, but try to * Nits (requests for small changes that are not essential) are fine, but try to
avoid stalling the pull request. avoid stalling the pull request.
* Note that they are nits when you comment: `Nit: change foo() to bar().` * Identify them as nits when you comment: `Nit: change foo() to bar().`
* If they are stalling the pull request, fix them yourself on merge. * If they are stalling the pull request, fix them yourself on merge.
* Insofar as possible, issues should be identified by tools rather than human * Insofar as possible, issues should be identified by tools rather than human
reviewers. If you are leaving comments about issues that could be identified reviewers. If you are leaving comments about issues that could be identified
@ -191,7 +191,7 @@ onboarding session.
See the Collaborator Guide: [Landing Pull Requests][]. See the Collaborator Guide: [Landing Pull Requests][].
Note that commits in one PR that belong to one logical change should Commits in one PR that belong to one logical change should
be squashed. It is rarely the case in onboarding exercises, so this be squashed. It is rarely the case in onboarding exercises, so this
needs to be pointed out separately during the onboarding. needs to be pointed out separately during the onboarding.