1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove common.inspect()

Browse Source 
common.inspect() is just util.inspect(). common copies every property
from util but this is the only one that gets used and it only gets used
in three places. Well, four, but the fourth is removed in a pending PR.

This commit removes it. Subsequently, the "copy util to common"
part of `common` can be removed altogether.

PR-URL: https://github.com/nodejs/node/pull/3257
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
This commit is contained in:
Rich Trott 2015-10-07 20:53:38 -07:00
parent a1040f2065
commit 72c8a74b55
3 changed files with 9 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
test/parallel/test-fs-realpath.js
View File

@ -93,15 +93,9 @@ function test_simple_relative_symlink(callback) {
unlink.push(t[0]);
});
var result = fs.realpathSync(entry);
assert.equal(result, path.resolve(expected),
'got ' + common.inspect(result) + ' expected ' +
common.inspect(expected));
assert.equal(result, path.resolve(expected));
asynctest(fs.realpath, [entry], callback, function(err, result) {
assert.equal(result, path.resolve(expected),
'got ' +
common.inspect(result) +
' expected ' +
common.inspect(expected));
assert.equal(result, path.resolve(expected));
});
}
@ -125,17 +119,9 @@ function test_simple_absolute_symlink(callback) {
unlink.push(t[0]);
});
var result = fs.realpathSync(entry);
assert.equal(result, path.resolve(expected),
'got ' +
common.inspect(result) +
' expected ' +
common.inspect(expected));
assert.equal(result, path.resolve(expected));
asynctest(fs.realpath, [entry], callback, function(err, result) {
assert.equal(result, path.resolve(expected),
'got ' +
common.inspect(result) +
' expected ' +
common.inspect(expected));
assert.equal(result, path.resolve(expected));
});
}
@ -163,11 +149,7 @@ function test_deep_relative_file_symlink(callback) {
assert.equal(fs.realpathSync(entry), path.resolve(expected));
asynctest(fs.realpath, [entry], callback, function(err, result) {
assert.equal(result, path.resolve(expected),
'got ' +
common.inspect(result) +
' expected ' +
common.inspect(path.resolve(expected)));
assert.equal(result, path.resolve(expected));
});
}
@ -195,11 +177,7 @@ function test_deep_relative_dir_symlink(callback) {
assert.equal(fs.realpathSync(entry), path.resolve(expected));
asynctest(fs.realpath, [entry], callback, function(err, result) {
assert.equal(result, path.resolve(expected),
'got ' +
common.inspect(result) +
' expected ' +
common.inspect(path.resolve(expected)));
assert.equal(result, path.resolve(expected));
});
}
@ -280,11 +258,7 @@ function test_relative_input_cwd(callback) {
assert.equal(fs.realpathSync(entry), path.resolve(expected));
asynctest(fs.realpath, [entry], callback, function(err, result) {
process.chdir(origcwd);
assert.equal(result, path.resolve(expected),
'got ' +
common.inspect(result) +
' expected ' +
common.inspect(path.resolve(expected)));
assert.equal(result, path.resolve(expected));
return true;
});
}
@ -336,11 +310,7 @@ function test_deep_symlink_mix(callback) {
var expected = tmpAbsDir + '/cycles/root.js';
assert.equal(fs.realpathSync(entry), path.resolve(expected));
asynctest(fs.realpath, [entry], callback, function(err, result) {
assert.equal(result, path.resolve(expected),
'got ' +
common.inspect(result) +
' expected ' +
common.inspect(path.resolve(expected)));
assert.equal(result, path.resolve(expected));
return true;
});
}
@ -355,11 +325,7 @@ function test_non_symlinks(callback) {
assert.equal(fs.realpathSync(entry), path.resolve(expected));
asynctest(fs.realpath, [entry], callback, function(err, result) {
process.chdir(origcwd);
assert.equal(result, path.resolve(expected),
'got ' +
common.inspect(result) +
' expected ' +
common.inspect(path.resolve(expected)));
assert.equal(result, path.resolve(expected));
return true;
});
}

1
test/parallel/test-memory-usage.js
View File

@ -3,5 +3,4 @@ var common = require('../common');
var assert = require('assert');
var r = process.memoryUsage();
console.log(common.inspect(r));
assert.equal(true, r['rss'] > 0);

1
test/sequential/test-memory-usage-emfile.js
View File

@ -10,5 +10,4 @@ while (files.length < 256)
files.push(fs.openSync(__filename, 'r'));
var r = process.memoryUsage();
console.log(common.inspect(r));
assert.equal(true, r['rss'] > 0);