1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve test for crypto padding

Browse Source 
Replace assert.equal with assert.strictEqual and use RegExp in
assert.throws

PR-URL: https://github.com/nodejs/node/pull/9906
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Julian Duque 2016-12-01 10:21:00 -06:00 committed by Rich Trott
parent 6d54c879d6
commit 72b1f79a64
1 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
test/parallel/test-crypto-padding.js
View File

@ -74,16 +74,18 @@ function dec(encd, pad) {
* Test encryption * Test encryption
*/ */
assert.equal(enc(ODD_LENGTH_PLAIN, true), ODD_LENGTH_ENCRYPTED); assert.strictEqual(enc(ODD_LENGTH_PLAIN, true), ODD_LENGTH_ENCRYPTED);
assert.equal(enc(EVEN_LENGTH_PLAIN, true), EVEN_LENGTH_ENCRYPTED); assert.strictEqual(enc(EVEN_LENGTH_PLAIN, true), EVEN_LENGTH_ENCRYPTED);
assert.throws(function() { assert.throws(function() {
// input must have block length % // input must have block length %
enc(ODD_LENGTH_PLAIN, false); enc(ODD_LENGTH_PLAIN, false);
}); }, /data not multiple of block length/);
assert.doesNotThrow(function() { assert.doesNotThrow(function() {
assert.equal(enc(EVEN_LENGTH_PLAIN, false), EVEN_LENGTH_ENCRYPTED_NOPAD); assert.strictEqual(
enc(EVEN_LENGTH_PLAIN, false), EVEN_LENGTH_ENCRYPTED_NOPAD
);
}); });
@ -91,21 +93,25 @@ assert.doesNotThrow(function() {
* Test decryption * Test decryption
*/ */
assert.equal(dec(ODD_LENGTH_ENCRYPTED, true), ODD_LENGTH_PLAIN); assert.strictEqual(dec(ODD_LENGTH_ENCRYPTED, true), ODD_LENGTH_PLAIN);
assert.equal(dec(EVEN_LENGTH_ENCRYPTED, true), EVEN_LENGTH_PLAIN); assert.strictEqual(dec(EVEN_LENGTH_ENCRYPTED, true), EVEN_LENGTH_PLAIN);
assert.doesNotThrow(function() { assert.doesNotThrow(function() {
// returns including original padding // returns including original padding
assert.equal(dec(ODD_LENGTH_ENCRYPTED, false).length, 32); assert.strictEqual(dec(ODD_LENGTH_ENCRYPTED, false).length, 32);
assert.equal(dec(EVEN_LENGTH_ENCRYPTED, false).length, 48); assert.strictEqual(dec(EVEN_LENGTH_ENCRYPTED, false).length, 48);
}); });
assert.throws(function() { assert.throws(function() {
// must have at least 1 byte of padding (PKCS): // must have at least 1 byte of padding (PKCS):
assert.equal(dec(EVEN_LENGTH_ENCRYPTED_NOPAD, true), EVEN_LENGTH_PLAIN); assert.strictEqual(
}); dec(EVEN_LENGTH_ENCRYPTED_NOPAD, true), EVEN_LENGTH_PLAIN
);
}, /bad decrypt/);
assert.doesNotThrow(function() { assert.doesNotThrow(function() {
// no-pad encrypted string should return the same: // no-pad encrypted string should return the same:
assert.equal(dec(EVEN_LENGTH_ENCRYPTED_NOPAD, false), EVEN_LENGTH_PLAIN); assert.strictEqual(
dec(EVEN_LENGTH_ENCRYPTED_NOPAD, false), EVEN_LENGTH_PLAIN
);
}); });