1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: use common.PORT instead of an extraneous variable

Browse Source 
This test is not parallelized and so we can use the test commons PORT
variable.

Refs: https://github.com/nodejs/node/pull/27565#discussion_r281000162

PR-URL: https://github.com/nodejs/node/pull/27565
Fixes: https://github.com/nodejs/node/issues/27341
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Benjamin Ki 2019-05-04 21:28:32 -04:00 committed by Rich Trott
parent 402a793012
commit 7294897c77
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/internet/test-dgram-connect.js
View File

@ -5,17 +5,15 @@ const { addresses } = require('../common/internet');
const assert = require('assert'); const assert = require('assert');
const dgram = require('dgram'); const dgram = require('dgram');
const PORT = 12345;
const client = dgram.createSocket('udp4'); const client = dgram.createSocket('udp4');
client.connect(PORT, addresses.INVALID_HOST, common.mustCall((err) => { client.connect(common.PORT, addresses.INVALID_HOST, common.mustCall((err) => {
assert.ok(err.code === 'ENOTFOUND' || err.code === 'EAI_AGAIN'); assert.ok(err.code === 'ENOTFOUND' || err.code === 'EAI_AGAIN');
client.once('error', common.mustCall((err) => { client.once('error', common.mustCall((err) => {
assert.ok(err.code === 'ENOTFOUND' || err.code === 'EAI_AGAIN'); assert.ok(err.code === 'ENOTFOUND' || err.code === 'EAI_AGAIN');
client.once('connect', common.mustCall(() => client.close())); client.once('connect', common.mustCall(() => client.close()));
client.connect(PORT); client.connect(common.PORT);
})); }));
client.connect(PORT, addresses.INVALID_HOST); client.connect(common.PORT, addresses.INVALID_HOST);
})); }));