1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

events: fix TypeError in removeAllListeners

Browse Source 
Check that `listeners` is actually an array before trying to manipulate it
because it won't be if no regular event listeners have been registered yet
but there are 'removeListener' event listeners.
This commit is contained in:
Jeremy Martin 2013-11-22 09:17:16 -05:00 committed by Ben Noordhuis
parent a34bbaf31b
commit 71aabedad4
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/events.js
View File

@ -263,7 +263,7 @@ EventEmitter.prototype.removeAllListeners = function(type) {
if (typeof listeners === 'function') {
this.removeListener(type, listeners);
} else {
} else if (Array.isArray(listeners)) {
// LIFO order
while (listeners.length)
this.removeListener(type, listeners[listeners.length - 1]);

7
test/simple/test-event-emitter-remove-all-listeners.js
View File

@ -71,3 +71,10 @@ e2.removeAllListeners();
console.error(e2);
assert.deepEqual([], e2.listeners('foo'));
assert.deepEqual([], e2.listeners('bar'));
var e3 = new events.EventEmitter();
e3.on('removeListener', listener);
// check for regression where removeAllListeners throws when
// there exists a removeListener listener, but there exists
// no listeners for the provided event type
assert.doesNotThrow(e3.removeAllListeners.bind(e3, 'foo'));