1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix arguments order in assertions

Browse Source 
Have the actual value first & the expected value second.

PR-URL: https://github.com/nodejs/node/pull/24149
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Emanuel Kluge 2018-11-06 16:15:02 +01:00 committed by Gireesh Punathil
parent 49b0f7fa19
commit 6eda924c18
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/parallel/test-process-env.js
View File

@ -26,12 +26,12 @@ const assert = require('assert');
// changes in environment should be visible to child processes // changes in environment should be visible to child processes
if (process.argv[2] === 'you-are-the-child') { if (process.argv[2] === 'you-are-the-child') {
assert.strictEqual(false, 'NODE_PROCESS_ENV_DELETED' in process.env); assert.strictEqual('NODE_PROCESS_ENV_DELETED' in process.env, false);
assert.strictEqual('42', process.env.NODE_PROCESS_ENV); assert.strictEqual(process.env.NODE_PROCESS_ENV, '42');
assert.strictEqual('asdf', process.env.hasOwnProperty); assert.strictEqual(process.env.hasOwnProperty, 'asdf');
const hasOwnProperty = Object.prototype.hasOwnProperty; const hasOwnProperty = Object.prototype.hasOwnProperty;
const has = hasOwnProperty.call(process.env, 'hasOwnProperty'); const has = hasOwnProperty.call(process.env, 'hasOwnProperty');
assert.strictEqual(true, has); assert.strictEqual(has, true);
process.exit(0); process.exit(0);
} }
@ -41,18 +41,18 @@ if (process.argv[2] === 'you-are-the-child') {
assert.strictEqual(Object.prototype.hasOwnProperty, assert.strictEqual(Object.prototype.hasOwnProperty,
process.env.hasOwnProperty); process.env.hasOwnProperty);
const has = process.env.hasOwnProperty('hasOwnProperty'); const has = process.env.hasOwnProperty('hasOwnProperty');
assert.strictEqual(false, has); assert.strictEqual(has, false);
process.env.hasOwnProperty = 'asdf'; process.env.hasOwnProperty = 'asdf';
process.env.NODE_PROCESS_ENV = 42; process.env.NODE_PROCESS_ENV = 42;
assert.strictEqual('42', process.env.NODE_PROCESS_ENV); assert.strictEqual(process.env.NODE_PROCESS_ENV, '42');
process.env.NODE_PROCESS_ENV_DELETED = 42; process.env.NODE_PROCESS_ENV_DELETED = 42;
assert.strictEqual(true, 'NODE_PROCESS_ENV_DELETED' in process.env); assert.strictEqual('NODE_PROCESS_ENV_DELETED' in process.env, true);
delete process.env.NODE_PROCESS_ENV_DELETED; delete process.env.NODE_PROCESS_ENV_DELETED;
assert.strictEqual(false, 'NODE_PROCESS_ENV_DELETED' in process.env); assert.strictEqual('NODE_PROCESS_ENV_DELETED' in process.env, false);
const child = spawn(process.argv[0], [process.argv[1], 'you-are-the-child']); const child = spawn(process.argv[0], [process.argv[1], 'you-are-the-child']);
child.stdout.on('data', function(data) { console.log(data.toString()); }); child.stdout.on('data', function(data) { console.log(data.toString()); });