1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src,win: fix usage of deprecated v8::Object::Set

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/26735
Refs: https://github.com/nodejs/node/issues/26733
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This commit is contained in:
Michaël Zasso 2019-03-18 13:50:26 +01:00 committed by Refael Ackermann
parent cf51ee4dcf
commit 6e678b1b59
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/api/exceptions.cc
View File

@ -213,16 +213,22 @@ Local<Value> WinapiErrnoException(Isolate* isolate,
}
Local<Object> obj = e.As<Object>();
obj->Set(env->errno_string(), Integer::New(isolate, errorno));
obj->Set(env->context(), env->errno_string(), Integer::New(isolate, errorno))
.FromJust();
if (path != nullptr) {
obj->Set(env->path_string(),
obj->Set(env->context(),
env->path_string(),
String::NewFromUtf8(isolate, path, NewStringType::kNormal)
.ToLocalChecked());
.ToLocalChecked())
.FromJust();
}
if (syscall != nullptr) {
obj->Set(env->syscall_string(), OneByteString(isolate, syscall));
obj->Set(env->context(),
env->syscall_string(),
OneByteString(isolate, syscall))
.FromJust();
}
if (must_free)