1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "build: avoid compiling with VS v17.12"

Browse Source 
This reverts commit 542f252d3672f586db07112fe2d844a5d1417e3a.

PR-URL: https://github.com/nodejs/node/pull/56151
Refs: https://github.com/nodejs/build/issues/3963
Refs: https://github.com/nodejs/node/pull/55930
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
This commit is contained in:
Gerhard Stöbich 2024-12-07 23:31:45 +01:00 committed by GitHub
parent ac7fea6a12
commit 6e42433054
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
vcbuild.bat
View File

@ -292,19 +292,10 @@ goto exit
@rem Visual Studio v17.10 has a bug that causes the build to fail.
@rem Check if the version is v17.10 and exit if it is.
echo %VSCMD_VER% | findstr /b /c:"17.10" >nul
if %errorlevel% neq 1 (
if %errorlevel% neq 1 (
echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version.
goto exit
)
@rem Same applies to v17.12 for MSVC.
echo %VSCMD_VER% | findstr /b /c:"17.12" >nul
if %errorlevel% neq 1 (
@rem Clang 18.1.8 Provided with VS 17.12 works fine.
if not defined clang_cl (
echo Node.js doesn't compile with Visual Studio 17.12 Please use a different version.
goto exit
)
)
@rem check if the clang-cl build is requested
if not defined clang_cl goto clang-skip