From 6d5847917c50751608d263e3cd59bc1d66d6e1e9 Mon Sep 17 00:00:00 2001 From: Matheus Marchini Date: Tue, 29 May 2018 11:50:46 -0300 Subject: [PATCH] test: mark test-fs-readfile-tostring-fail as flaky test-fs-readfile-tostring-fail is failing frequently on OSX machines. There's a PR to fix this issue in libuv, but while the fix don't land on Node.js this test should be marked as flaky. Ref: https://github.com/nodejs/node/issues/16601 Ref: https://github.com/libuv/libuv/pull/1742 PR-URL: https://github.com/nodejs/node/pull/21013 Refs: https://github.com/nodejs/node/issues/16601 Refs: https://github.com/libuv/libuv/pull/1742 Reviewed-By: Ruben Bridgewater Reviewed-By: Jon Moss Reviewed-By: Luigi Pinca Reviewed-By: Anatoli Papirovski Reviewed-By: Michael Dawson Reviewed-By: James M Snell Reviewed-By: Trivikram Kamat Reviewed-By: Gireesh Punathil --- test/sequential/sequential.status | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status index cf4763b0012..07df25bbc75 100644 --- a/test/sequential/sequential.status +++ b/test/sequential/sequential.status @@ -15,6 +15,9 @@ test-inspector-async-hook-setup-at-signal: PASS, FLAKY [$system==linux] [$system==macos] +# This test will be flaky until https://github.com/libuv/libuv/pull/1742 lands +# on Node.js. +test-fs-readfile-tostring-fail: PASS, FLAKY [$system==solaris] # Also applies to SmartOS