1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-timers-this

Browse Source 
* use common.mustCall() and eliminate exit handler
* provide timer durtion of 1ms where previously omitted
* var -> const

PR-URL: https://github.com/nodejs/node/pull/10315
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This commit is contained in:
Rich Trott 2016-12-16 22:05:01 -08:00
parent ffd01da0f2
commit 6cb33c0764
1 changed files with 20 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
test/parallel/test-timers-this.js
View File

@ -1,45 +1,29 @@
'use strict';
require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');
let immediateThis, intervalThis, timeoutThis;
let immediateArgsThis, intervalArgsThis, timeoutArgsThis;
const immediateHandler = setImmediate(common.mustCall(function() {
assert.strictEqual(this, immediateHandler);
}));
var immediateHandler = setImmediate(function() {
immediateThis = this;
});
const immediateArgsHandler = setImmediate(common.mustCall(function() {
assert.strictEqual(this, immediateArgsHandler);
}), 'args ...');
var immediateArgsHandler = setImmediate(function() {
immediateArgsThis = this;
}, 'args ...');
var intervalHandler = setInterval(function() {
const intervalHandler = setInterval(common.mustCall(function() {
clearInterval(intervalHandler);
assert.strictEqual(this, intervalHandler);
}), 1);
intervalThis = this;
});
var intervalArgsHandler = setInterval(function() {
const intervalArgsHandler = setInterval(common.mustCall(function() {
clearInterval(intervalArgsHandler);
assert.strictEqual(this, intervalArgsHandler);
}), 1, 'args ...');
intervalArgsThis = this;
}, 0, 'args ...');
const timeoutHandler = setTimeout(common.mustCall(function() {
assert.strictEqual(this, timeoutHandler);
}), 1);
var timeoutHandler = setTimeout(function() {
timeoutThis = this;
});
var timeoutArgsHandler = setTimeout(function() {
timeoutArgsThis = this;
}, 0, 'args ...');
process.once('exit', function() {
assert.strictEqual(immediateThis, immediateHandler);
assert.strictEqual(immediateArgsThis, immediateArgsHandler);
assert.strictEqual(intervalThis, intervalHandler);
assert.strictEqual(intervalArgsThis, intervalArgsHandler);
assert.strictEqual(timeoutThis, timeoutHandler);
assert.strictEqual(timeoutArgsThis, timeoutArgsHandler);
});
const timeoutArgsHandler = setTimeout(common.mustCall(function() {
assert.strictEqual(this, timeoutArgsHandler);
}), 1, 'args ...');