From 6c38ab34a301f76a2d5f306ddc242d2bebbd8f53 Mon Sep 17 00:00:00 2001
From: Simon Brewster <ssbrewster@gmail.com>
Date: Mon, 18 Sep 2017 21:33:10 +0200
Subject: [PATCH] http2: improved coverage of Http2Stream destroy

Refs: https://github.com/nodejs/node/issues/14985
PR-URL: https://github.com/nodejs/node/pull/15461
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 ...st-http2-server-destroy-before-priority.js | 41 +++++++++++++++++++
 .../test-http2-server-destroy-before-rst.js   | 41 +++++++++++++++++++
 .../test-http2-server-destroy-before-state.js | 37 +++++++++++++++++
 3 files changed, 119 insertions(+)
 create mode 100644 test/parallel/test-http2-server-destroy-before-priority.js
 create mode 100644 test/parallel/test-http2-server-destroy-before-rst.js
 create mode 100644 test/parallel/test-http2-server-destroy-before-state.js

diff --git a/test/parallel/test-http2-server-destroy-before-priority.js b/test/parallel/test-http2-server-destroy-before-priority.js
new file mode 100644
index 00000000000..74d7c011ba0
--- /dev/null
+++ b/test/parallel/test-http2-server-destroy-before-priority.js
@@ -0,0 +1,41 @@
+// Flags: --expose-http2
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+const assert = require('assert');
+const http2 = require('http2');
+
+const server = http2.createServer();
+
+// Test that ERR_HTTP2_INVALID_STREAM is thrown when a stream is destroyed
+// before calling stream.priority
+server.on('stream', common.mustCall(onStream));
+
+function onStream(stream, headers, flags) {
+  stream.session.destroy();
+  assert.throws(() => stream.priority(),
+                common.expectsError({
+                  code: 'ERR_HTTP2_INVALID_STREAM',
+                  message: /^The stream has been destroyed$/
+                }));
+}
+
+server.listen(0);
+
+server.on('listening', common.mustCall(() => {
+
+  const client = http2.connect(`http://localhost:${server.address().port}`);
+
+  const req = client.request({ ':path': '/' });
+
+  req.on('response', common.mustNotCall());
+  req.resume();
+  req.on('end', common.mustCall(() => {
+    server.close();
+    client.destroy();
+  }));
+  req.end();
+
+}));
diff --git a/test/parallel/test-http2-server-destroy-before-rst.js b/test/parallel/test-http2-server-destroy-before-rst.js
new file mode 100644
index 00000000000..f066e76b5f9
--- /dev/null
+++ b/test/parallel/test-http2-server-destroy-before-rst.js
@@ -0,0 +1,41 @@
+// Flags: --expose-http2
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+const assert = require('assert');
+const http2 = require('http2');
+
+const server = http2.createServer();
+
+// Test that ERR_HTTP2_INVALID_STREAM is thrown when a stream is destroyed
+// before calling stream.rstStream
+server.on('stream', common.mustCall(onStream));
+
+function onStream(stream, headers, flags) {
+  stream.session.destroy();
+  assert.throws(() => stream.rstStream(),
+                common.expectsError({
+                  code: 'ERR_HTTP2_INVALID_STREAM',
+                  message: /^The stream has been destroyed$/
+                }));
+}
+
+server.listen(0);
+
+server.on('listening', common.mustCall(() => {
+
+  const client = http2.connect(`http://localhost:${server.address().port}`);
+
+  const req = client.request({ ':path': '/' });
+
+  req.on('response', common.mustNotCall());
+  req.resume();
+  req.on('end', common.mustCall(() => {
+    server.close();
+    client.destroy();
+  }));
+  req.end();
+
+}));
diff --git a/test/parallel/test-http2-server-destroy-before-state.js b/test/parallel/test-http2-server-destroy-before-state.js
new file mode 100644
index 00000000000..f5dce3e30a2
--- /dev/null
+++ b/test/parallel/test-http2-server-destroy-before-state.js
@@ -0,0 +1,37 @@
+// Flags: --expose-http2
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+const assert = require('assert');
+const http2 = require('http2');
+
+const server = http2.createServer();
+
+// Test that stream.state getter returns and empty object
+// if the stream session has been destroyed
+server.on('stream', common.mustCall(onStream));
+
+function onStream(stream, headers, flags) {
+  stream.session.destroy();
+  assert.deepStrictEqual(Object.create(null), stream.state);
+}
+
+server.listen(0);
+
+server.on('listening', common.mustCall(() => {
+
+  const client = http2.connect(`http://localhost:${server.address().port}`);
+
+  const req = client.request({ ':path': '/' });
+
+  req.on('response', common.mustNotCall());
+  req.resume();
+  req.on('end', common.mustCall(() => {
+    server.close();
+    client.destroy();
+  }));
+  req.end();
+
+}));