1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: updated guidance for n-api changes

Browse Source 
Add js_native_api.h and js_native_api_types.h to the list
of files covered by the N-API guidance as these were
broken out of the files referenced.

Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: https://github.com/nodejs/node/pull/32721
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This commit is contained in:
Michael Dawson 2020-04-08 11:32:49 -04:00 committed by Anna Henningsen
parent cecb08f0c8
commit 6c2c905948
No known key found for this signature in database
GPG Key ID: A94130F0BFC8EBE9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/guides/collaborator-guide.md
View File

@ -332,8 +332,8 @@ For pull requests introducing new core modules:
### Additions to N-API ### Additions to N-API
N-API provides an ABI-stable API guaranteed for future Node.js versions. N-API N-API provides an ABI-stable API guaranteed for future Node.js versions. N-API
additions call for unusual care and scrutiny. If a change adds to `node_api.h` additions call for unusual care and scrutiny. If a change adds to `node_api.h`,
or `node_api_types.h`, consult [the relevant `js_native_api.h`, `node_api_types.h`, or `js_native_api_types.h`, consult [the relevant
guide](https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md). guide](https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md).
### Deprecations ### Deprecations