1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: use dynamic port in test-cluster-dgram-reuse

Browse Source 
Remove common.PORT from test-cluster-dgram-reuse to eliminate
possibility that a dynamic port used in another test will collide with
common.PORT.

PR-URL: https://github.com/nodejs/node/pull/12901
Ref: https://github.com/nodejs/node/issues/12376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
This commit is contained in:
Artur Vieira 2017-05-08 09:38:53 +00:00 committed by Luigi Pinca
parent 847688018c
commit 6b1819cff5
1 changed files with 13 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
test/parallel/test-cluster-dgram-reuse.js
View File

@ -16,24 +16,22 @@ if (cluster.isMaster) {
return; return;
} }
const sockets = [];
function next() {
sockets.push(this);
if (sockets.length !== 2)
return;
// Work around health check issue
process.nextTick(() => {
for (let i = 0; i < sockets.length; i++)
sockets[i].close(close);
});
}
let waiting = 2; let waiting = 2;
function close() { function close() {
if (--waiting === 0) if (--waiting === 0)
cluster.worker.disconnect(); cluster.worker.disconnect();
} }
for (let i = 0; i < 2; i++) const options = { type: 'udp4', reuseAddr: true };
dgram.createSocket({ type: 'udp4', reuseAddr: true }).bind(common.PORT, next); const socket1 = dgram.createSocket(options);
const socket2 = dgram.createSocket(options);
socket1.bind(0, () => {
socket2.bind(socket1.address().port, () => {
// Work around health check issue
process.nextTick(() => {
socket1.close(close);
socket2.close(close);
});
});
});