1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-dgram-oob-buffer

Browse Source 
* Change common.noop to common.mustNotCall() to verify callback is not
  invoked.
* Add destructuring assignment for clarity. Yeah, clarity. That's why.

PR-URL: https://github.com/nodejs/node/pull/13443
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit is contained in:
Rich Trott 2017-06-03 13:22:57 -07:00
parent d6260a8f4b
commit 6b070654e6
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/parallel/test-dgram-oob-buffer.js
View File

@ -31,14 +31,14 @@ const socket = dgram.createSocket('udp4');
const buf = Buffer.from([1, 2, 3, 4]); const buf = Buffer.from([1, 2, 3, 4]);
const portGetter = dgram.createSocket('udp4') const portGetter = dgram.createSocket('udp4')
.bind(0, 'localhost', common.mustCall(() => { .bind(0, 'localhost', common.mustCall(() => {
const address = portGetter.address(); const { address, port } = portGetter.address();
portGetter.close(common.mustCall(() => { portGetter.close(common.mustCall(() => {
socket.send(buf, 0, 0, address.port, address.address, common.noop); socket.send(buf, 0, 0, port, address, common.mustNotCall());
socket.send(buf, 0, 4, address.port, address.address, common.noop); socket.send(buf, 0, 4, port, address, common.mustNotCall());
socket.send(buf, 1, 3, address.port, address.address, common.noop); socket.send(buf, 1, 3, port, address, common.mustNotCall());
socket.send(buf, 3, 1, address.port, address.address, common.noop); socket.send(buf, 3, 1, port, address, common.mustNotCall());
// Since length of zero means nothing, don't error despite OOB. // Since length of zero means nothing, don't error despite OOB.
socket.send(buf, 4, 0, address.port, address.address, common.noop); socket.send(buf, 4, 0, port, address, common.mustNotCall());
socket.close(); socket.close();
})); }));