1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: fix -Wunused-result compiler warning

Browse Source 
Fix a warning that was introduced in commit 67af1ad ("src: refactor
CopyProperties to remove JS") from a few days ago.  This particular
change was suggested by me, mea culpa.

Fixes the following warning:

    ../src/node_contextify.cc:151:13: warning: ignoring return
    value of function declared with warn_unused_result attribute
    [-Wunused-result]
                sandbox_obj->DefineProperty(context, key, *desc);

PR-URL: https://github.com/nodejs/node/pull/11197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit is contained in:
Ben Noordhuis 2017-02-06 14:33:36 +01:00
parent 039a813ff0
commit 6af0bfe1a0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/node_contextify.cc
View File

@ -148,7 +148,7 @@ class ContextifyContext {
desc->set_enumerable(desc_vm_context desc->set_enumerable(desc_vm_context
->Get(context, env()->enumerable_string()).ToLocalChecked() ->Get(context, env()->enumerable_string()).ToLocalChecked()
->BooleanValue(context).FromJust()); ->BooleanValue(context).FromJust());
sandbox_obj->DefineProperty(context, key, *desc); CHECK(sandbox_obj->DefineProperty(context, key, *desc).FromJust());
}; };
if (is_accessor) { if (is_accessor) {