1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: disable fs watch tests for AIX

Browse Source 
fs watch currently needs special configuration on AIX and we
want to improve under https://github.com/nodejs/node/issues/5085.
Tests are disabled so CI can be green and we can spot other
regressions until this work is complete.

test-async-wrap-check-providers does not aim to test fs watch
but part of the test uses it so that part has been skipped for
AIX

PR-URL: https://github.com/nodejs/node/pull/5187
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit is contained in:
Michael Dawson 2016-02-10 15:56:26 -05:00
parent aa0526972a
commit 6a85ad9391
3 changed files with 32 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/parallel/parallel.status
View File

@ -20,3 +20,10 @@ test-tick-processor : PASS,FLAKY
[$system==solaris] # Also applies to SmartOS [$system==solaris] # Also applies to SmartOS
[$system==freebsd] [$system==freebsd]
# fs-watch currently needs special configuration on AIX and we
# want to improve under https://github.com/nodejs/node/issues/5085.
# Tests are disabled so CI can be green and we can spot other
# regressions until this work is complete
[$system==aix]
test-fs-watch-enoent : FAIL, PASS

22
test/parallel/test-async-wrap-check-providers.js
View File

@ -18,6 +18,16 @@ let keyList = pkeys.slice();
// Drop NONE // Drop NONE
keyList.splice(0, 1); keyList.splice(0, 1);
// fs-watch currently needs special configuration on AIX and we
// want to improve under https://github.com/nodejs/node/issues/5085.
// strip out fs watch related parts for now
if (common.isAix) {
for (var i = 0; i < keyList.length; i++) {
if ((keyList[i] === 'FSEVENTWRAP') || (keyList[i] === 'STATWATCHER')) {
keyList.splice(i, 1);
}
}
}
function init(id) { function init(id) {
keyList = keyList.filter((e) => e != pkeys[id]); keyList = keyList.filter((e) => e != pkeys[id]);
@ -33,9 +43,15 @@ async_wrap.enable();
setTimeout(function() { }); setTimeout(function() { });
fs.stat(__filename, noop); fs.stat(__filename, noop);
fs.watchFile(__filename, noop);
fs.unwatchFile(__filename); if (!common.isAix) {
fs.watch(__filename).close(); // fs-watch currently needs special configuration on AIX and we
// want to improve under https://github.com/nodejs/node/issues/5085.
// strip out fs watch related parts for now
fs.watchFile(__filename, noop);
fs.unwatchFile(__filename);
fs.watch(__filename).close();
}
dns.lookup('localhost', noop); dns.lookup('localhost', noop);
dns.lookupService('::', 0, noop); dns.lookupService('::', 0, noop);

6
test/sequential/sequential.status
View File

@ -17,3 +17,9 @@ test-vm-syntax-error-stderr : PASS,FLAKY
[$system==freebsd] [$system==freebsd]
# fs-watch currently needs special configuration on AIX and we
# want to improve under https://github.com/nodejs/node/issues/5085.
# Tests are disabled so CI can be green and we can spot other
# regressions until this work is complete
[$system==aix]
test-fs-watch : FAIL, PASS