1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tools: generate template literal for addon tests

Browse Source 
Instead of generating string concatenation, generate a template literal.
This is mostly useful as a pre-emptive measure for avoiding problems
when (if?) we enable the prefer-template lint rule in the test
directory.

PR-URL: https://github.com/nodejs/node/pull/14094
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit is contained in:
Rich Trott 2017-07-05 14:43:55 -07:00
parent 0d22858d67
commit 6a1b8135d6
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/doc/addon-verify.js
View File

@ -66,7 +66,10 @@ function verifyFiles(files, blockName, onprogress, ondone) {
if (name === 'test.js') { if (name === 'test.js') {
files[name] = `'use strict'; files[name] = `'use strict';
const common = require('../../common'); const common = require('../../common');
${files[name].replace('Release', "' + common.buildType + '")} ${files[name].replace(
"'./build/Release/addon'",
// eslint-disable-next-line no-template-curly-in-string
'`./build/${common.buildType}/addon`')}
`; `;
} }
return { return {