1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lib: simplify several debug() calls

Browse Source 
Avoid calling Array.prototype.join() in debug() calls. These
are evaluated on every call, even if the debug() call is a
no-op. This commit replaces the join() calls with the %j
placeholder.

PR-URL: https://github.com/nodejs/node/pull/25241
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
cjihrig 2018-12-27 10:06:23 -05:00
parent baf03962c1
commit 69470c87cc
No known key found for this signature in database
GPG Key ID: 7434390BDBE9B9C5
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/internal/http2/core.js
View File

@ -477,8 +477,8 @@ function onOrigin(origins) {
const session = this[kOwner]; const session = this[kOwner];
if (session.destroyed) if (session.destroyed)
return; return;
debug(`Http2Session ${sessionName(session[kType])}: origin received: ` + debug('Http2Session %s: origin received: %j',
`${origins.join(', ')}`); sessionName(session[kType]), origins);
session[kUpdateTimer](); session[kUpdateTimer]();
if (!session.encrypted || session.destroyed) if (!session.encrypted || session.destroyed)
return undefined; return undefined;

4
lib/internal/modules/esm/create_dynamic_module.js
View File

@ -6,9 +6,7 @@ const ArrayJoin = Function.call.bind(Array.prototype.join);
const ArrayMap = Function.call.bind(Array.prototype.map); const ArrayMap = Function.call.bind(Array.prototype.map);
const createDynamicModule = (exports, url = '', evaluate) => { const createDynamicModule = (exports, url = '', evaluate) => {
debug( debug('creating ESM facade for %s with exports: %j', url, exports);
`creating ESM facade for ${url} with exports: ${ArrayJoin(exports, ', ')}`
);
const names = ArrayMap(exports, (name) => `${name}`); const names = ArrayMap(exports, (name) => `${name}`);
const source = ` const source = `