1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: remove Socket.prototype.write

Browse Source 
This is superfluous now that typechecking in `net` and
`stream` are aligned.

PR-URL: https://github.com/nodejs/node/pull/17644
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
This commit is contained in:
Anna Henningsen 2017-12-13 07:39:29 +01:00 committed by Ruben Bridgewater
parent 19b4485477
commit 6918fff9c9
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/net.js
View File

@ -701,17 +701,6 @@ protoGetter('localPort', function localPort() {
}); });
Socket.prototype.write = function(chunk, encoding, cb) {
if (typeof chunk !== 'string' && !(chunk instanceof Buffer)) {
throw new errors.TypeError('ERR_INVALID_ARG_TYPE',
'chunk',
['string', 'Buffer'],
chunk);
}
return stream.Duplex.prototype.write.apply(this, arguments);
};
Socket.prototype._writeGeneric = function(writev, data, encoding, cb) { Socket.prototype._writeGeneric = function(writev, data, encoding, cb) {
// If we are still connecting, then buffer this for later. // If we are still connecting, then buffer this for later.
// The Writable logic will buffer up any more writes while // The Writable logic will buffer up any more writes while