1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: remove "note that" from writing-and-running-benchmarks.md

Browse Source 
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/16

PR-URL: https://github.com/nodejs/node/pull/28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Rich Trott 2019-06-20 13:27:15 -06:00
parent ca276253fb
commit 68cfa56d0c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/guides/writing-and-running-benchmarks.md
View File

@ -352,7 +352,7 @@ The arguments of `createBenchmark` are:
* `configs` {Object} The benchmark parameters. `createBenchmark` will run all * `configs` {Object} The benchmark parameters. `createBenchmark` will run all
possible combinations of these parameters, unless specified otherwise. possible combinations of these parameters, unless specified otherwise.
Each configuration is a property with an array of possible values. Each configuration is a property with an array of possible values.
Note that the configuration values can only be strings or numbers. The configuration values can only be strings or numbers.
* `options` {Object} The benchmark options. At the moment only the `flags` * `options` {Object} The benchmark options. At the moment only the `flags`
option for specifying command line flags is supported. option for specifying command line flags is supported.
@ -400,7 +400,7 @@ const options = {
// `main` and `configs` are required, `options` is optional. // `main` and `configs` are required, `options` is optional.
const bench = common.createBenchmark(main, configs, options); const bench = common.createBenchmark(main, configs, options);
// Note that any code outside main will be run twice, // Any code outside main will be run twice,
// in different processes, with different command line arguments. // in different processes, with different command line arguments.
function main(conf) { function main(conf) {