1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

crypto: use less memory for storing keys

Browse Source 
Use `BIO_new_mem_buf` where possible to reduce memory usage and
initialization costs.
This commit is contained in:
Fedor Indutny 2014-09-01 16:07:45 +04:00
parent 4bd396a9bf
commit 68c14d6923
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/node_crypto.cc
View File

@ -3283,13 +3283,10 @@ SignBase::Error Sign::SignFinal(const char* key_pem,
EVP_PKEY* pkey = NULL; EVP_PKEY* pkey = NULL;
bool fatal = true; bool fatal = true;
bp = BIO_new(BIO_s_mem()); bp = BIO_new_mem_buf(const_cast<char*>(key_pem), key_pem_len);
if (bp == NULL) if (bp == NULL)
goto exit; goto exit;
if (!BIO_write(bp, key_pem, key_pem_len))
goto exit;
pkey = PEM_read_bio_PrivateKey(bp, pkey = PEM_read_bio_PrivateKey(bp,
NULL, NULL,
CryptoPemCallback, CryptoPemCallback,
@ -3475,13 +3472,10 @@ SignBase::Error Verify::VerifyFinal(const char* key_pem,
bool fatal = true; bool fatal = true;
int r = 0; int r = 0;
bp = BIO_new(BIO_s_mem()); bp = BIO_new_mem_buf(const_cast<char*>(key_pem), key_pem_len);
if (bp == NULL) if (bp == NULL)
goto exit; goto exit;
if (!BIO_write(bp, key_pem, key_pem_len))
goto exit;
// Check if this is a PKCS#8 or RSA public key before trying as X.509. // Check if this is a PKCS#8 or RSA public key before trying as X.509.
// Split this out into a separate function once we have more than one // Split this out into a separate function once we have more than one
// consumer of public keys. // consumer of public keys.
@ -3595,13 +3589,10 @@ bool PublicKeyCipher::Cipher(const char* key_pem,
X509* x509 = NULL; X509* x509 = NULL;
bool fatal = true; bool fatal = true;
bp = BIO_new(BIO_s_mem()); bp = BIO_new_mem_buf(const_cast<char*>(key_pem), key_pem_len);
if (bp == NULL) if (bp == NULL)
goto exit; goto exit;
if (!BIO_write(bp, key_pem, key_pem_len))
goto exit;
// Check if this is a PKCS#8 or RSA public key before trying as X.509 and // Check if this is a PKCS#8 or RSA public key before trying as X.509 and
// private key. // private key.
if (operation == kEncrypt && if (operation == kEncrypt &&