1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: improve COLLABORATOR_GUIDE

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/23977
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Jagannath Bhat 2018-10-30 23:08:04 +05:30 committed by Rich Trott
parent ed8562517e
commit 67d74e400b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
COLLABORATOR_GUIDE.md
View File

@ -497,7 +497,7 @@ This should be done where a pull request:
Assign the `tsc-review` label or @-mention the Assign the `tsc-review` label or @-mention the
`@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][]. `@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][].
Do not use the GitHub UI on the right hand side to assign to Do not use the GitHub UI on the right-hand side to assign to
`@nodejs/tsc` or request a review from `@nodejs/tsc`. `@nodejs/tsc` or request a review from `@nodejs/tsc`.
The TSC should serve as the final arbiter where required. The TSC should serve as the final arbiter where required.
@ -528,7 +528,7 @@ The TSC should serve as the final arbiter where required.
you are unsure exactly how to format the commit messages, use the commit log you are unsure exactly how to format the commit messages, use the commit log
as a reference. See [this commit][commit-example] as an example. as a reference. See [this commit][commit-example] as an example.
For PRs from first time contributors, be [welcoming](#welcoming-first-time-contributors). For PRs from first-time contributors, be [welcoming](#welcoming-first-time-contributors).
Also, verify that their git settings are to their liking. Also, verify that their git settings are to their liking.
All commits should be self-contained, meaning every commit should pass all All commits should be self-contained, meaning every commit should pass all