1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: fix flaky async-hooks/test-callback-error

Browse Source 
Remove an unnecessary timeout.

Fixes: https://github.com/nodejs/node/issues/15985

PR-URL: https://github.com/nodejs/node/pull/22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Anna Henningsen 2018-09-02 15:39:43 +02:00
parent b3eb3a19ad
commit 67bfcb78f6
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/async-hooks/test-callback-error.js
View File

@ -58,10 +58,6 @@ assert.ok(!arg);
{
console.log('start case 3');
console.time('end case 3');
// Timeout is set because this case is known to be problematic, so stderr is
// logged for further analysis.
// Ref: https://github.com/nodejs/node/issues/13527
// Ref: https://github.com/nodejs/node/pull/13559
const opts = {
execArgv: ['--abort-on-uncaught-exception'],
silent: true
@ -78,15 +74,7 @@ assert.ok(!arg);
stderr += data;
});
const tO = setTimeout(() => {
console.log(stderr);
child.kill('SIGKILL');
process.exit(1);
}, 15 * 1000);
tO.unref();
child.on('close', (code, signal) => {
clearTimeout(tO);
if (common.isWindows) {
assert.strictEqual(code, 134);
assert.strictEqual(signal, null);