1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor stdio handling in test-esm-cjs-main

Browse Source 
Set encoding on the stderr/stdout streams instead of calling
data.toString(). Don't assume the complete expected messages arrive in
a single event.

PR-URL: https://github.com/nodejs/node/pull/25169
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This commit is contained in:
Richard Lau 2018-12-21 13:20:21 -05:00 committed by Daniel Bevenius
parent 3614157b78
commit 67b724fa77
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
test/es-module/test-esm-cjs-main.js
View File

@ -8,21 +8,20 @@ const assert = require('assert');
const entry = fixtures.path('/es-modules/cjs.js'); const entry = fixtures.path('/es-modules/cjs.js');
const child = spawn(process.execPath, ['--experimental-modules', entry]); const child = spawn(process.execPath, ['--experimental-modules', entry]);
let experimentalWarning = false; let stderr = '';
let validatedExecution = false; child.stderr.setEncoding('utf8');
child.stderr.on('data', (data) => { child.stderr.on('data', (data) => {
if (!experimentalWarning) { stderr += data;
experimentalWarning = true;
return;
}
throw new Error(data.toString());
}); });
let stdout = '';
child.stdout.setEncoding('utf8');
child.stdout.on('data', (data) => { child.stdout.on('data', (data) => {
assert.strictEqual(data.toString(), 'executed\n'); stdout += data;
validatedExecution = true;
}); });
child.on('close', common.mustCall((code, signal) => { child.on('close', common.mustCall((code, signal) => {
assert.strictEqual(validatedExecution, true);
assert.strictEqual(code, 0); assert.strictEqual(code, 0);
assert.strictEqual(signal, null); assert.strictEqual(signal, null);
assert.strictEqual(stdout, 'executed\n');
assert.strictEqual(stderr, `(node:${child.pid}) ` +
'ExperimentalWarning: The ESM module loader is experimental.\n');
})); }));