1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

buffer: use correct name for custom inspect symbol

Browse Source 
59714cb7b3918c9e4fcd94013b778078d3710705 introduced the
`util.inspect.custom` symbol, but it was exported as
`customInspectSymbol` by `internal/util.js` and referenced as
`inspectSymbol` by `buffer.js`.

PR-URL: https://github.com/nodejs/node/pull/9289
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Charmander 2016-10-25 22:27:14 -07:00 committed by James M Snell
parent 690bdede13
commit 66d54467c5
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/buffer.js
View File

@ -527,7 +527,7 @@ Buffer.prototype.equals = function equals(b) {
// Override how buffers are presented by util.inspect(). // Override how buffers are presented by util.inspect().
Buffer.prototype[internalUtil.inspectSymbol] = function inspect() { Buffer.prototype[internalUtil.customInspectSymbol] = function inspect() {
var str = ''; var str = '';
var max = exports.INSPECT_MAX_BYTES; var max = exports.INSPECT_MAX_BYTES;
if (this.length > 0) { if (this.length > 0) {
@ -537,7 +537,7 @@ Buffer.prototype[internalUtil.inspectSymbol] = function inspect() {
} }
return '<' + this.constructor.name + ' ' + str + '>'; return '<' + this.constructor.name + ' ' + str + '>';
}; };
Buffer.prototype.inspect = Buffer.prototype[internalUtil.inspectSymbol]; Buffer.prototype.inspect = Buffer.prototype[internalUtil.customInspectSymbol];
Buffer.prototype.compare = function compare(target, Buffer.prototype.compare = function compare(target,
start, start,

3
test/parallel/test-buffer-inspect.js
View File

@ -34,3 +34,6 @@ assert.doesNotThrow(function() {
assert.strictEqual(util.inspect(b), expected); assert.strictEqual(util.inspect(b), expected);
assert.strictEqual(util.inspect(s), expected); assert.strictEqual(util.inspect(s), expected);
}); });
b.inspect = undefined;
assert.strictEqual(util.inspect(b), expected);