From 656bf7d0b8f69efd70595558ca1094b3f33af3d6 Mon Sep 17 00:00:00 2001 From: Dario Piotrowicz Date: Tue, 13 May 2025 13:10:36 +0100 Subject: [PATCH] doc: update commit-queue documentation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit update the commit-queue contributing documentation by: - removing the references of the feature being experimental - clarifying that it applies to mergeable pull requests PR-URL: https://github.com/nodejs/node/pull/58275 Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel Reviewed-By: Ulises Gascón Reviewed-By: Richard Lau Reviewed-By: Michael Dawson Reviewed-By: Matteo Collina Reviewed-By: Chengzhong Wu --- doc/contributing/commit-queue.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/doc/contributing/commit-queue.md b/doc/contributing/commit-queue.md index cece9ea84e9..a47b1d84f29 100644 --- a/doc/contributing/commit-queue.md +++ b/doc/contributing/commit-queue.md @@ -1,10 +1,8 @@ # Commit queue -> Stability: 1 - Experimental - _tl;dr: You can land pull requests by adding the `commit-queue` label to it._ -Commit Queue is an experimental feature for the project which simplifies the +Commit Queue is a feature for the project which simplifies the landing process by automating it via GitHub Actions. With it, collaborators can land pull requests by adding the `commit-queue` label to a PR. All checks will run via `@node-core/utils`, and if the pull request is ready to @@ -18,7 +16,7 @@ implementation details, reasoning for design choices, and current limitations. From a high-level, the Commit Queue works as follow: 1. Collaborators will add `commit-queue` label to pull requests ready to land -2. Every five minutes the queue will do the following for each pull request +2. Every five minutes the queue will do the following for each mergeable pull request with the label: 1. Check if the PR also has a `request-ci` label (if it has, skip this PR since it's pending a CI run)