assert: avoid potentially misleading reference to object identity
Often, the word “identical” when referring to JS objects will be read as referring to having the same object identity (which is called “reference equality” here), but what the error message is trying to say here is that the objects are different but yield the same `util.inspect()` output. Since `util.inspect()` output represents the structure rather than the identity of objects, (hopefully) clarify the error message to reflect that. PR-URL: https://github.com/nodejs/node/pull/28824 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
parent
48e13d2adf
commit
64e4b0c0ac
@ -22,7 +22,7 @@ const kReadableOperator = {
|
||||
notStrictEqualObject:
|
||||
'Expected "actual" not to be reference-equal to "expected":',
|
||||
notDeepEqual: 'Expected "actual" not to be loosely deep-equal to:',
|
||||
notIdentical: 'Values identical but not reference-equal:',
|
||||
notIdentical: 'Values have same structure but are not reference-equal:',
|
||||
notDeepEqualUnequal: 'Expected values not to be loosely deep-equal:'
|
||||
};
|
||||
|
||||
|
@ -1101,7 +1101,7 @@ assert.throws(() => { throw null; }, 'foo');
|
||||
assert.throws(
|
||||
() => assert.strictEqual([], []),
|
||||
{
|
||||
message: 'Values identical but not reference-equal:\n\n[]\n'
|
||||
message: 'Values have same structure but are not reference-equal:\n\n[]\n'
|
||||
}
|
||||
);
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user