1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove FIXME pummel/test-tls-securepair-client

Browse Source 
Reverts: 85827bd
Using `common.PORT` no longer causes other tests to fail

Refs: https://github.com/nodejs/node/issues/4640
PR-URL: https://github.com/nodejs/node/pull/8757
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Alfred Cepeda 2016-09-24 07:26:05 -04:00 committed by James M Snell
parent 0f944ab3cf
commit 647e8e5ae4
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/pummel/test-tls-securepair-client.js
View File

@ -39,12 +39,6 @@ function test2() {
}
function test(keyfn, certfn, check, next) {
// FIXME: Avoid the common PORT as this test currently hits a C-level
// assertion error with node_g. The program aborts without HUPing
// the openssl s_server thus causing many tests to fail with
// EADDRINUSE.
var PORT = common.PORT + 5;
keyfn = join(common.fixturesDir, keyfn);
var key = fs.readFileSync(keyfn).toString();
@ -52,7 +46,7 @@ function test(keyfn, certfn, check, next) {
var cert = fs.readFileSync(certfn).toString();
var server = spawn(common.opensslCli, ['s_server',
'-accept', PORT,
'-accept', common.PORT,
'-cert', certfn,
'-key', keyfn]);
server.stdout.pipe(process.stdout);
@ -121,7 +115,7 @@ function test(keyfn, certfn, check, next) {
pair.encrypted.pipe(s);
s.pipe(pair.encrypted);
s.connect(PORT);
s.connect(common.PORT);
s.on('connect', function() {
console.log('client connected');