1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve test-fs-empty-readStream.js

Browse Source 
* use const instead of var
* use common.mustCall to control functions execution
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: https://github.com/nodejs/node/pull/10479
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
This commit is contained in:
Adrian Estrada 2016-12-27 21:43:44 -05:00 committed by James M Snell
parent 1bee74de84
commit 6463ef6aff
1 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
test/parallel/test-fs-empty-readStream.js
View File

@ -1,30 +1,30 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var path = require('path');
var fs = require('fs');
const common = require('../common');
const assert = require('assert');
const path = require('path');
const fs = require('fs');
var emptyFile = path.join(common.fixturesDir, 'empty.txt');
const emptyFile = path.join(common.fixturesDir, 'empty.txt');
fs.open(emptyFile, 'r', function(error, fd) {
fs.open(emptyFile, 'r', common.mustCall((error, fd) => {
assert.ifError(error);
var read = fs.createReadStream(emptyFile, { 'fd': fd });
const read = fs.createReadStream(emptyFile, { 'fd': fd });
read.once('data', function() {
read.once('data', () => {
throw new Error('data event should not emit');
});
read.once('end', common.mustCall(function endEvent1() {}));
});
}));
fs.open(emptyFile, 'r', function(error, fd) {
fs.open(emptyFile, 'r', common.mustCall((error, fd) => {
assert.ifError(error);
var read = fs.createReadStream(emptyFile, { 'fd': fd });
const read = fs.createReadStream(emptyFile, { 'fd': fd });
read.pause();
read.once('data', function() {
read.once('data', () => {
throw new Error('data event should not emit');
});
@ -32,7 +32,7 @@ fs.open(emptyFile, 'r', function(error, fd) {
throw new Error('end event should not emit');
});
setTimeout(function() {
assert.equal(read.isPaused(), true);
}, common.platformTimeout(50));
});
setTimeout(common.mustCall(() => {
assert.strictEqual(read.isPaused(), true);
}), common.platformTimeout(50));
}));