1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

crypto: remove outdated comment

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/21511
Fixes: https://github.com/nodejs/node/issues/21488
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Timothy Gu 2018-06-24 15:30:17 -04:00
parent 28100bbe6d
commit 6396574cde
No known key found for this signature in database
GPG Key ID: 7FE6B095B582B0D4
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/node_crypto.cc
View File

@ -2154,9 +2154,6 @@ void SSLWrap<Base>::VerifyError(const FunctionCallbackInfo<Value>& args) {
if (x509_verify_error == X509_V_OK) if (x509_verify_error == X509_V_OK)
return args.GetReturnValue().SetNull(); return args.GetReturnValue().SetNull();
// XXX(bnoordhuis) X509_verify_cert_error_string() is not actually thread-safe
// in the presence of invalid error codes. Probably academical but something
// to keep in mind if/when node ever grows multi-isolate capabilities.
const char* reason = X509_verify_cert_error_string(x509_verify_error); const char* reason = X509_verify_cert_error_string(x509_verify_error);
const char* code = reason; const char* code = reason;
#define CASE_X509_ERR(CODE) case X509_V_ERR_##CODE: code = #CODE; break; #define CASE_X509_ERR(CODE) case X509_V_ERR_##CODE: code = #CODE; break;