1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

url: fix off-by-one error in loop handling dots

Browse Source 
Fixes an error where a loop, used to traverse an array of length `n`,
ran `n + 1` times instead of `n`.

PR-URL: https://github.com/nodejs/node/pull/8420
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
Luigi Pinca 2016-09-06 12:51:47 +02:00 committed by James M Snell
parent 73bafa0d81
commit 63493e1cb3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/url.js
View File

@ -852,7 +852,7 @@ Url.prototype.resolveObject = function(relative) {
// strip single dots, resolve double dots to parent dir // strip single dots, resolve double dots to parent dir
// if the path tries to go above the root, `up` ends up > 0 // if the path tries to go above the root, `up` ends up > 0
var up = 0; var up = 0;
for (var i = srcPath.length; i >= 0; i--) { for (var i = srcPath.length - 1; i >= 0; i--) {
last = srcPath[i]; last = srcPath[i];
if (last === '.') { if (last === '.') {
spliceOne(srcPath, i); spliceOne(srcPath, i);