1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: make addon testing part of make test

Browse Source 
Otherwise it's too easy to miss breaking changes to node.h and other
public headers until the CI catches them.  `vcbuild test` tests addons
so there is precedence.

PR-URL: https://github.com/nodejs/node/pull/6232
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This commit is contained in:
Ben Noordhuis 2016-04-15 21:19:21 +02:00
parent fa542ebcfd
commit 628ae25795
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Makefile
View File

@ -114,9 +114,9 @@ v8:
tools/make-v8.sh v8 tools/make-v8.sh v8
$(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS) $(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS)
test: | cctest # Depends on 'all'. test: | build-addons cctest # Both targets depend on 'all'.
$(PYTHON) tools/test.py --mode=release -J \ $(PYTHON) tools/test.py --mode=release -J \
doctool message parallel sequential addon doctool message parallel sequential
$(MAKE) lint $(MAKE) lint
test-parallel: all test-parallel: all
@ -141,7 +141,10 @@ ADDONS_BINDING_GYPS := \
$(wildcard test/addons/*/binding.gyp)) $(wildcard test/addons/*/binding.gyp))
# Implicitly depends on $(NODE_EXE), see the build-addons rule for rationale. # Implicitly depends on $(NODE_EXE), see the build-addons rule for rationale.
test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) | test/addons/.docbuildstamp test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) \
deps/uv/include/*.h deps/v8/include/*.h \
src/node.h src/node_buffer.h src/node_object_wrap.h \
| test/addons/.docbuildstamp
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before # Cannot use $(wildcard test/addons/*/) here, it's evaluated before
# embedded addons have been generated from the documentation. # embedded addons have been generated from the documentation.
for dirname in test/addons/*/; do \ for dirname in test/addons/*/; do \