1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

buffer: don't predefine error

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/17021
Fixes: https://github.com/nodejs/node/issues/16994
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
buji 2017-11-14 19:41:46 +08:00 committed by Anna Henningsen
parent 66e2751e0a
commit 6244070c48
No known key found for this signature in database
GPG Key ID: 9C63F3A6CD2AD8F9
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/buffer.js
View File

@ -447,14 +447,12 @@ Buffer.isEncoding = function isEncoding(encoding) {
}; };
Buffer[kIsEncodingSymbol] = Buffer.isEncoding; Buffer[kIsEncodingSymbol] = Buffer.isEncoding;
const kConcatErr = new errors.TypeError(
'ERR_INVALID_ARG_TYPE', 'list', ['Array', 'Buffer', 'Uint8Array']
);
Buffer.concat = function concat(list, length) { Buffer.concat = function concat(list, length) {
var i; var i;
if (!Array.isArray(list)) if (!Array.isArray(list))
throw kConcatErr; throw new errors.TypeError(
'ERR_INVALID_ARG_TYPE', 'list', ['Array', 'Buffer', 'Uint8Array']
);
if (list.length === 0) if (list.length === 0)
return new FastBuffer(); return new FastBuffer();
@ -472,7 +470,9 @@ Buffer.concat = function concat(list, length) {
for (i = 0; i < list.length; i++) { for (i = 0; i < list.length; i++) {
var buf = list[i]; var buf = list[i];
if (!isUint8Array(buf)) if (!isUint8Array(buf))
throw kConcatErr; throw new errors.TypeError(
'ERR_INVALID_ARG_TYPE', 'list', ['Array', 'Buffer', 'Uint8Array']
);
_copy(buf, buffer, pos); _copy(buf, buffer, pos);
pos += buf.length; pos += buf.length;
} }