1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: refactor onSlaveClose in Server.close

Browse Source 
Refactors onSlaveClose in Server.close to be an arrow function,
removes need for `self = this` and moves it down to make code
more readable.

PR-URL: https://github.com/nodejs/node/pull/12334
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
This commit is contained in:
Claudio Rodriguez 2017-04-11 10:39:25 +01:00
parent 6c606916db
commit 615167bed6
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/net.js
View File

@ -1539,13 +1539,6 @@ Server.prototype.getConnections = function(cb) {
Server.prototype.close = function(cb) {
function onSlaveClose() {
if (--left !== 0) return;
self._connections = 0;
self._emitCloseIfDrained();
}
if (typeof cb === 'function') {
if (!this._handle) {
this.once('close', function close() {
@ -1562,8 +1555,13 @@ Server.prototype.close = function(cb) {
}
if (this._usingSlaves) {
var self = this;
var left = this._slaves.length;
const onSlaveClose = () => {
if (--left !== 0) return;
this._connections = 0;
this._emitCloseIfDrained();
};
// Increment connections to be sure that, even if all sockets will be closed
// during polling of slaves, `close` event will be emitted only once.