src: remove env-inl.h from header files

Inline headers should only be included into the .cc files that use them.

PR-URL: https://github.com/nodejs/node/pull/27755
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Sam Roberts 2019-05-17 13:36:05 -07:00
parent 2ecef9b5f2
commit 60b315c064
20 changed files with 22 additions and 8 deletions

View File

@ -1,4 +1,4 @@
#include "env.h" #include "env-inl.h"
#include "node.h" #include "node.h"
#include "node_context_data.h" #include "node_context_data.h"
#include "node_errors.h" #include "node_errors.h"

View File

@ -1,3 +1,4 @@
#include "env-inl.h"
#include "node.h" #include "node.h"
#include "node_internals.h" #include "node_internals.h"
#include "util-inl.h" #include "util-inl.h"

View File

@ -1,4 +1,5 @@
#include "debug_utils.h" #include "debug_utils.h"
#include "env-inl.h"
#include "util-inl.h" #include "util-inl.h"
#ifdef __POSIX__ #ifdef __POSIX__

View File

@ -4,7 +4,7 @@
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
#include "async_wrap.h" #include "async_wrap.h"
#include "env-inl.h" #include "env.h"
#include <sstream> #include <sstream>
#include <string> #include <string>

View File

@ -1,5 +1,6 @@
#include "inspector_agent.h" #include "inspector_agent.h"
#include "env-inl.h"
#include "inspector/main_thread_interface.h" #include "inspector/main_thread_interface.h"
#include "inspector/node_string.h" #include "inspector/node_string.h"
#include "inspector/runtime_agent.h" #include "inspector/runtime_agent.h"

View File

@ -2,6 +2,7 @@
#include <cmath> #include <cmath>
#include <algorithm> #include <algorithm>
#define NAPI_EXPERIMENTAL #define NAPI_EXPERIMENTAL
#include "env-inl.h"
#include "js_native_api_v8.h" #include "js_native_api_v8.h"
#include "js_native_api.h" #include "js_native_api.h"
#include "util-inl.h" #include "util-inl.h"

View File

@ -1,5 +1,5 @@
#include <node_buffer.h> #include <node_buffer.h>
#include "env.h" #include "env-inl.h"
#define NAPI_EXPERIMENTAL #define NAPI_EXPERIMENTAL
#include "js_native_api_v8.h" #include "js_native_api_v8.h"
#include "node_api.h" #include "node_api.h"

View File

@ -19,6 +19,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE. // USE OR OTHER DEALINGS IN THE SOFTWARE.
#include "env-inl.h"
#include "node_constants.h" #include "node_constants.h"
#include "node_internals.h" #include "node_internals.h"
#include "util-inl.h" #include "util-inl.h"

View File

@ -1,3 +1,4 @@
#include "env-inl.h"
#include "node_internals.h" #include "node_internals.h"
#include "util-inl.h" #include "util-inl.h"

View File

@ -24,7 +24,7 @@
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
#include "env-inl.h" #include "env.h"
#include "node.h" #include "node.h"
#include "node_binding.h" #include "node_binding.h"
#include "node_mutex.h" #include "node_mutex.h"

View File

@ -1,3 +1,4 @@
#include "env-inl.h"
#include "node_report.h" #include "node_report.h"
#include "debug_utils.h" #include "debug_utils.h"
#include "node_internals.h" #include "node_internals.h"

View File

@ -1,3 +1,4 @@
#include "env-inl.h"
#include "node_internals.h" #include "node_internals.h"
#include "node_report.h" #include "node_report.h"
#include "util-inl.h" #include "util-inl.h"

View File

@ -4,7 +4,7 @@
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
#include "node.h" #include "node.h"
#include "env-inl.h" #include "env.h"
#include <string> #include <string>

View File

@ -19,11 +19,13 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE. // USE OR OTHER DEALINGS IN THE SOFTWARE.
#include "node_watchdog.h"
#include <algorithm> #include <algorithm>
#include "debug_utils.h" #include "debug_utils.h"
#include "env-inl.h"
#include "node_errors.h" #include "node_errors.h"
#include "node_internals.h" #include "node_internals.h"
#include "node_watchdog.h"
#include "util-inl.h" #include "util-inl.h"
namespace node { namespace node {

View File

@ -22,6 +22,7 @@
#include "util.h" // NOLINT(build/include_inline) #include "util.h" // NOLINT(build/include_inline)
#include "util-inl.h" #include "util-inl.h"
#include "env-inl.h"
#include "node_buffer.h" #include "node_buffer.h"
#include "node_errors.h" #include "node_errors.h"
#include "node_internals.h" #include "node_internals.h"

View File

@ -7,7 +7,7 @@
#include "node.h" #include "node.h"
#include "node_platform.h" #include "node_platform.h"
#include "node_internals.h" #include "node_internals.h"
#include "env.h" #include "env-inl.h"
#include "util-inl.h" #include "util-inl.h"
#include "v8.h" #include "v8.h"
#include "libplatform/libplatform.h" #include "libplatform/libplatform.h"

View File

@ -1,4 +1,3 @@
#include "v8.h" #include "v8.h"
#include "aliased_buffer.h" #include "aliased_buffer.h"
#include "node_test_fixture.h" #include "node_test_fixture.h"

View File

@ -1,5 +1,6 @@
#include "node_url.h" #include "node_url.h"
#include "node_i18n.h" #include "node_i18n.h"
#include "util-inl.h"
#include "gtest/gtest.h" #include "gtest/gtest.h"

View File

@ -177,6 +177,7 @@ def ReadMacros(macro_files):
TEMPLATE = """ TEMPLATE = """
#include "env-inl.h"
#include "node_native_module.h" #include "node_native_module.h"
#include "node_internals.h" #include "node_internals.h"

View File

@ -5,9 +5,11 @@
#include <string> #include <string>
#include <vector> #include <vector>
#include "env-inl.h"
#include "libplatform/libplatform.h" #include "libplatform/libplatform.h"
#include "node_internals.h" #include "node_internals.h"
#include "snapshot_builder.h" #include "snapshot_builder.h"
#include "util-inl.h"
#include "v8.h" #include "v8.h"
#ifdef _WIN32 #ifdef _WIN32