1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

buffer: fix missing null/undefined check

Browse Source 
The new implementation of Buffer missed the check for null/undefined as
the first argument to new Buffer(). Reintroduce the check and add test.

Fix: e8734c0 "buffer: implement Uint8Array backed Buffer"
Fix: https://github.com/nodejs/io.js/issues/2194
PR-URL: https://github.com/nodejs/io.js/pull/2195
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
This commit is contained in:
Trevor Norris 2015-07-16 15:19:01 -06:00 committed by Rod Vagg
parent 2ba8b23661
commit 60a974d200
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/buffer.js
View File

@ -105,6 +105,10 @@ function fromObject(obj) {
return b; return b;
} }
if (obj == null) {
throw new TypeError('must start with number, buffer, array or string');
}
if (obj instanceof ArrayBuffer) { if (obj instanceof ArrayBuffer) {
return binding.createFromArrayBuffer(obj); return binding.createFromArrayBuffer(obj);
} }

8
test/parallel/test-buffer.js
View File

@ -1181,3 +1181,11 @@ Buffer.poolSize = ps;
assert.throws(function() { assert.throws(function() {
Buffer(10).copy(); Buffer(10).copy();
}); });
assert.throws(function() {
new Buffer();
}, /must start with number, buffer, array or string/);
assert.throws(function() {
new Buffer(null);
}, /must start with number, buffer, array or string/);