1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: check uv_ip4_addr return value

Browse Source 
Fixes Coverity errors.

PR-URL: https://github.com/nodejs/node/pull/13878
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit is contained in:
Eugene Ostroukhov 2017-06-22 10:43:03 -07:00
parent 6bf4c23295
commit 5fbbd25dc4
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/cctest/test_inspector_socket.cc
View File

@ -370,7 +370,7 @@ class InspectorSocketTest : public ::testing::Test {
sockaddr_in addr; sockaddr_in addr;
uv_tcp_init(&loop, &server); uv_tcp_init(&loop, &server);
uv_tcp_init(&loop, &client_socket); uv_tcp_init(&loop, &client_socket);
uv_ip4_addr("127.0.0.1", PORT, &addr); GTEST_ASSERT_EQ(0, uv_ip4_addr("127.0.0.1", PORT, &addr));
uv_tcp_bind(&server, reinterpret_cast<const struct sockaddr*>(&addr), 0); uv_tcp_bind(&server, reinterpret_cast<const struct sockaddr*>(&addr), 0);
GTEST_ASSERT_EQ(0, uv_listen(reinterpret_cast<uv_stream_t*>(&server), GTEST_ASSERT_EQ(0, uv_listen(reinterpret_cast<uv_stream_t*>(&server),
1, on_new_connection)); 1, on_new_connection));

9
test/cctest/test_inspector_socket_server.cc
View File

@ -194,10 +194,11 @@ class SocketWrapper {
contents_.clear(); contents_.clear();
uv_tcp_init(loop_, &socket_); uv_tcp_init(loop_, &socket_);
sockaddr_in addr; sockaddr_in addr;
uv_ip4_addr(host.c_str(), port, &addr); int err = uv_ip4_addr(host.c_str(), port, &addr);
int err = uv_tcp_connect(&connect_, &socket_, ASSERT_EQ(0, err);
reinterpret_cast<const sockaddr*>(&addr), err = uv_tcp_connect(&connect_, &socket_,
ConnectionMustFail_); reinterpret_cast<const sockaddr*>(&addr),
ConnectionMustFail_);
ASSERT_EQ(0, err); ASSERT_EQ(0, err);
SPIN_WHILE(!connection_failed_) SPIN_WHILE(!connection_failed_)
uv_read_start(reinterpret_cast<uv_stream_t*>(&socket_), AllocCallback, uv_read_start(reinterpret_cast<uv_stream_t*>(&socket_), AllocCallback,