1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "test: skip test-cpu-prof in debug builds with code cache"

Browse Source 
Skipping the test is not needed now that the underlying cause
has been addressed in V8.

This reverts commit b66f01d9037a120a8aad624c57e769fb418ccd9c.

Refs: https://github.com/nodejs/node/pull/27423

PR-URL: https://github.com/nodejs/node/pull/27469
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Anna Henningsen 2019-04-29 01:35:07 +02:00 committed by Rich Trott
parent e1c838e7aa
commit 5f6848943e
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/sequential/test-cpu-prof.js
View File

@ -3,12 +3,6 @@
// This tests that --cpu-prof, --cpu-prof-dir and --cpu-prof-name works. // This tests that --cpu-prof, --cpu-prof-dir and --cpu-prof-name works.
const common = require('../common'); const common = require('../common');
if (process.features.debug && process.features.cached_builtins) {
// FIXME(joyeecheung): the profiler crashes when code cache
// is enabled in debug builds.
common.skip('--cpu-prof does not work in debug builds with code cache');
}
const fixtures = require('../common/fixtures'); const fixtures = require('../common/fixtures');
common.skipIfInspectorDisabled(); common.skipIfInspectorDisabled();