From 5ebc05f56018d5ced52e4c41f9e8a92c425253e3 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Mon, 5 Mar 2012 17:01:59 +0100 Subject: [PATCH] build: disable -fvisibility=hidden if gcc < 4.0.0 --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 27ef84e672c..00a8ed0d6bc 100755 --- a/configure +++ b/configure @@ -215,9 +215,9 @@ def configure_node(o): o['variables']['strict_aliasing'] = b( 'clang' in CC or gcc_version() >= [False, 4, 6, 0]) - # TODO move to node.gyp - if sys.platform == 'sunos5': - o['variables']['visibility'] = '' # FIXME -fvisibility=hidden, should be a gcc check + # clang has always supported -fvisibility=hidden, right? + if 'clang' not in CC and gcc_version() < [False, 4, 0, 0]: + o['variables']['visibility'] = '' def configure_libz(o):