1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tools: enable getter-return lint rule

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/26615
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This commit is contained in:
cjihrig 2019-03-12 14:39:06 -04:00
parent d989e20717
commit 5de804e636
No known key found for this signature in database
GPG Key ID: 7434390BDBE9B9C5
4 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc.js
View File

@ -83,6 +83,7 @@ module.exports = {
'func-call-spacing': 'error', 'func-call-spacing': 'error',
'func-name-matching': 'error', 'func-name-matching': 'error',
'func-style': ['error', 'declaration', { allowArrowFunctions: true }], 'func-style': ['error', 'declaration', { allowArrowFunctions: true }],
'getter-return': 'error',
'indent': ['error', 2, { 'indent': ['error', 2, {
ArrayExpression: 'first', ArrayExpression: 'first',
CallExpression: { arguments: 'first' }, CallExpression: { arguments: 'first' },

2
lib/internal/http2/compat.js
View File

@ -462,7 +462,7 @@ class Http2ServerResponse extends Stream {
// This is compatible with http1 which removes socket reference // This is compatible with http1 which removes socket reference
// only from ServerResponse but not IncomingMessage // only from ServerResponse but not IncomingMessage
if (this[kState].closed) if (this[kState].closed)
return; return undefined;
const stream = this[kStream]; const stream = this[kStream];
const proxySocket = stream[kProxySocket]; const proxySocket = stream[kProxySocket];

2
lib/net.js
View File

@ -495,7 +495,7 @@ Object.defineProperty(Socket.prototype, 'readyState', {
Object.defineProperty(Socket.prototype, 'bufferSize', { Object.defineProperty(Socket.prototype, 'bufferSize', {
get: function() { get: function() { // eslint-disable-line getter-return
if (this._handle) { if (this._handle) {
return this[kLastWriteQueueSize] + this.writableLength; return this[kLastWriteQueueSize] + this.writableLength;
} }

4
test/parallel/test-util-inspect.js
View File

@ -289,11 +289,11 @@ assert.strictEqual(
// Dynamic properties. // Dynamic properties.
{ {
assert.strictEqual( assert.strictEqual(
util.inspect({ get readonly() {} }), util.inspect({ get readonly() { return 1; } }),
'{ readonly: [Getter] }'); '{ readonly: [Getter] }');
assert.strictEqual( assert.strictEqual(
util.inspect({ get readwrite() {}, set readwrite(val) {} }), util.inspect({ get readwrite() { return 1; }, set readwrite(val) {} }),
'{ readwrite: [Getter/Setter] }'); '{ readwrite: [Getter/Setter] }');
assert.strictEqual( assert.strictEqual(