1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fs: add 'close' event to FSWatcher

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/19900
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Alec Larson 2018-04-09 15:00:18 -04:00 committed by Luigi Pinca
parent 809eb27bda
commit 5cc948b77a
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/api/fs.md
View File

@ -329,6 +329,13 @@ added: v0.5.8
Emitted when an error occurs while watching the file. Emitted when an error occurs while watching the file.
### Event: 'close'
<!-- YAML
added: REPLACEME
-->
Emitted when the watcher stops watching for changes.
### watcher.close() ### watcher.close()
<!-- YAML <!-- YAML
added: v0.5.8 added: v0.5.8

5
lib/fs.js
View File

@ -1387,8 +1387,13 @@ FSWatcher.prototype.close = function() {
return; return;
} }
this._handle.close(); this._handle.close();
process.nextTick(emitCloseNT, this);
}; };
function emitCloseNT(self) {
self.emit('close');
}
fs.watch = function(filename, options, listener) { fs.watch = function(filename, options, listener) {
if (typeof options === 'function') { if (typeof options === 'function') {
listener = options; listener = options;

1
test/parallel/test-fs-watch.js
View File

@ -54,6 +54,7 @@ for (const testCase of cases) {
} }
assert.fail(err); assert.fail(err);
}); });
watcher.on('close', common.mustCall());
watcher.on('change', common.mustCall(function(eventType, argFilename) { watcher.on('change', common.mustCall(function(eventType, argFilename) {
if (interval) { if (interval) {
clearInterval(interval); clearInterval(interval);