From 5c7af90cbf550d851eb4bfb0b8546bc48e381d46 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 24 Dec 2017 23:08:07 -0800 Subject: [PATCH] readline: refactor filter() callback Use construct that always returns a boolean for `filter()` callback. PR-URL: https://github.com/nodejs/node/pull/17858 Reviewed-By: Weijia Wang Reviewed-By: Tiancheng "Timothy" Gu Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: Khaidi Chu Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater --- lib/readline.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/readline.js b/lib/readline.js index 4df60afce8b..9b9a054fd66 100644 --- a/lib/readline.js +++ b/lib/readline.js @@ -500,9 +500,7 @@ Interface.prototype._tabComplete = function(lastKeypressWasTab) { } // If there is a common prefix to all matches, then apply that portion. - var f = completions.filter(function completionFilter(e) { - if (e) return e; - }); + var f = completions.filter((e) => e); var prefix = commonPrefix(f); if (prefix.length > completeOn.length) { self._insertString(prefix.slice(completeOn.length));