1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

errors: alter ERR_INVALID_PROTOCOL

Browse Source 
Changes the base instance for ERR_INVALID_PROTOCOL from Error to
TypeError as a more accurate representation of the error.

PR-URL: https://github.com/nodejs/node/pull/19983
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This commit is contained in:
davidmarkclements 2018-04-12 20:37:11 +02:00 committed by Luigi Pinca
parent f64bebf205
commit 5c425788f1
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/internal/errors.js
View File

@ -896,9 +896,9 @@ E('ERR_INVALID_OPT_VALUE_ENCODING',
'The value "%s" is invalid for option "encoding"', TypeError); 'The value "%s" is invalid for option "encoding"', TypeError);
E('ERR_INVALID_PERFORMANCE_MARK', E('ERR_INVALID_PERFORMANCE_MARK',
'The "%s" performance mark has not been set', Error); 'The "%s" performance mark has not been set', Error);
E('ERR_INVALID_PROTOCOL',
// This should probably be a `TypeError`. 'Protocol "%s" not supported. Expected "%s"',
E('ERR_INVALID_PROTOCOL', 'Protocol "%s" not supported. Expected "%s"', Error); TypeError);
E('ERR_INVALID_REPL_EVAL_CONFIG', E('ERR_INVALID_REPL_EVAL_CONFIG',
'Cannot specify both "breakEvalOnSigint" and "eval" for REPL', TypeError); 'Cannot specify both "breakEvalOnSigint" and "eval" for REPL', TypeError);
E('ERR_INVALID_SYNC_FORK_INPUT', E('ERR_INVALID_SYNC_FORK_INPUT',

2
test/parallel/test-http-url.parse-only-support-http-https-protocol.js
View File

@ -38,7 +38,7 @@ invalidUrls.forEach((invalid) => {
() => { http.request(url.parse(invalid)); }, () => { http.request(url.parse(invalid)); },
{ {
code: 'ERR_INVALID_PROTOCOL', code: 'ERR_INVALID_PROTOCOL',
type: Error type: TypeError
} }
); );
}); });