1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

buffer: fix writeUInt16BE range check

Browse Source 
Fixes: https://github.com/nodejs/node/issues/24205

PR-URL: https://github.com/nodejs/node/pull/24208
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Brian White 2018-11-06 18:16:16 -05:00 committed by Rich Trott
parent 00d412d3b7
commit 5c201b6d47
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/internal/buffer.js
View File

@ -667,7 +667,7 @@ function writeU_Int16BE(buf, value, offset, min, max) {
} }
function writeUInt16BE(value, offset = 0) { function writeUInt16BE(value, offset = 0) {
return writeU_Int16BE(this, value, offset, 0, 0xffffffff); return writeU_Int16BE(this, value, offset, 0, 0xffff);
} }
function writeIntLE(value, offset, byteLength) { function writeIntLE(value, offset, byteLength) {

12
test/parallel/test-buffer-writeuint.js
View File

@ -84,6 +84,18 @@ const assert = require('assert');
data.writeUInt16BE(value, 0); data.writeUInt16BE(value, 0);
assert.ok(data.equals(new Uint8Array([0xff, 0x80, 0x43, 0x23]))); assert.ok(data.equals(new Uint8Array([0xff, 0x80, 0x43, 0x23])));
value = 0xfffff;
['writeUInt16BE', 'writeUInt16LE'].forEach((fn) => {
assert.throws(
() => data[fn](value, 0),
{
code: 'ERR_OUT_OF_RANGE',
message: 'The value of "value" is out of range. ' +
`It must be >= 0 and <= 65535. Received ${value}`
}
);
});
} }
// Test 32 bit // Test 32 bit