1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http: add comments in _http_incoming

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/33035
Refs: https://github.com/nodejs/node/issues/30625
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Daniele Belardi 2020-12-09 13:31:02 +01:00 committed by Node.js GitHub Bot
parent 70eaf55a9d
commit 5ae9690869
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/_http_incoming.js
View File

@ -171,6 +171,9 @@ IncomingMessage.prototype._destroy = function _destroy(err, cb) {
// If aborted and the underlying socket not already destroyed,
// destroy it.
// We have to check if the socket is already destroyed because finished
// does not call the callback when this methdod is invoked from `_http_client`
// in `test/parallel/test-http-client-spurious-aborted.js`
if (this.socket && !this.socket.destroyed && this.aborted) {
this.socket.destroy(err);
const cleanup = finished(this.socket, (e) => {
@ -359,6 +362,9 @@ IncomingMessage.prototype._dump = function _dump() {
};
function onError(instance, cb, error) {
// This is to keep backward compatible behavior.
// An error is emitted only if there are listeners attached to
// the event.
if (instance.listenerCount('error') > 0) {
cb(error);
} else {