1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tls: fix initRead socket argument name

Browse Source 
"wrapped" argument is the caller's "socket", not its "wrap", and its
referred to as "socket" in the comments, so call it that.

PR-URL: https://github.com/nodejs/node/pull/25153
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This commit is contained in:
Sam Roberts 2018-12-19 14:30:20 -08:00
parent 08387b245e
commit 59aa94112e
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/_tls_wrap.js
View File

@ -271,15 +271,17 @@ function onerror(err) {
} }
} }
function initRead(tls, wrapped) { // Used by both client and server TLSSockets to start data flowing from _handle,
// read(0) causes a StreamBase::ReadStart, via Socket._read.
function initRead(tls, socket) {
// If we were destroyed already don't bother reading // If we were destroyed already don't bother reading
if (!tls._handle) if (!tls._handle)
return; return;
// Socket already has some buffered data - emulate receiving it // Socket already has some buffered data - emulate receiving it
if (wrapped && wrapped.readableLength) { if (socket && socket.readableLength) {
var buf; var buf;
while ((buf = wrapped.read()) !== null) while ((buf = socket.read()) !== null)
tls._handle.receive(buf); tls._handle.receive(buf);
} }